On Sat, Sep 07, 2024 at 17:15:17 +0300, Nikolai Barybin via Devel wrote: > Signed-off-by: Nikolai Barybin <nikolai.barybin@xxxxxxxxxxxxx> > --- > src/conf/storage_source_conf.c | 11 +++++++++++ > src/conf/storage_source_conf.h | 5 +++++ > 2 files changed, 16 insertions(+) > > diff --git a/src/conf/storage_source_conf.c b/src/conf/storage_source_conf.c > index 908bc5fab2..5d197ee3ca 100644 > --- a/src/conf/storage_source_conf.c > +++ b/src/conf/storage_source_conf.c > @@ -69,6 +69,7 @@ VIR_ENUM_IMPL(virStorageFileFeature, > VIR_STORAGE_FILE_FEATURE_LAST, > "lazy_refcounts", > "extended_l2", > + "data_file", > ); [..] > > diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h > index 05b4bda16c..fa27e61204 100644 > --- a/src/conf/storage_source_conf.h > +++ b/src/conf/storage_source_conf.h > @@ -88,6 +88,7 @@ VIR_ENUM_DECL(virStorageFileFormat); > typedef enum { > VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS = 0, > VIR_STORAGE_FILE_FEATURE_EXTENDED_L2, > + VIR_STORAGE_FILE_FEATURE_DATA_FILE, These hunks seems to belong to a different commit as this has nothing to do with fields in 'struct virStorageSource'. Please move them appropriately. Rest looks good.