Re: [PATCH 13/13] virsh: Add support for VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES migration parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 30, 2024 at 03:29:35PM +0200, Peter Krempa wrote:
> Expose the new parameter as '--migrate-disks-detect-zeroes' option.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  docs/manpages/virsh.rst |  8 +++++++-
>  tools/virsh-domain.c    | 26 ++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
> index f02a28156d..6665d46497 100644
> --- a/docs/manpages/virsh.rst
> +++ b/docs/manpages/virsh.rst
> @@ -3389,7 +3389,9 @@ migrate
>        [--postcopy-after-precopy] [--postcopy-resume] [--zerocopy]
>        domain desturi [migrateuri] [graphicsuri] [listen-address] [dname]
>        [--timeout seconds [--timeout-suspend | --timeout-postcopy]]
> -      [--xml file] [--migrate-disks disk-list] [--disks-port port]
> +      [--xml file]
> +      [--migrate-disks disk-list] [--migrate-disks-detect-zeroes disk-list]
> +      [--disks-port port]
>        [--compressed] [--comp-methods method-list]
>        [--comp-mt-level] [--comp-mt-threads] [--comp-mt-dthreads]
>        [--comp-xbzrle-cache] [--comp-zlib-level] [--comp-zstd-level]
> @@ -3420,6 +3422,10 @@ images on source host to the images found at the same place on the destination
>  host. By default only non-shared non-readonly images are transferred. Use
>  *--migrate-disks* to explicitly specify a list of disk targets to
>  transfer via the comma separated ``disk-list`` argument.
> +The *--migrate-disks-detect-zeroes* option which takes a comma separated list of
> +disk target names enables zeroed block detection for the listed migrated disks.

How about this wording:

Use *--migrate-disks-detect-zeroes* to specify which disks from
*--migrate-disks* list of disks should have zeroed block detection
enabled via the comma separated ``disk-list`` argument.

> +These blocks are not transferred or allocated on destination, effectively
> +sparsifying the disk at the cost of CPU overhead.
>  With *--copy-storage-synchronous-writes* flag used the disk data migration will
>  synchronously handle guest disk writes to both the original source and the
>  destination to ensure that the disk migration converges at the price of possibly

Pavel

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux