On Wed, Sep 18, 2024 at 10:34:31PM +0900, Andrea Bolognani wrote: > On Wed, Sep 18, 2024 at 03:02:58PM GMT, Daniel P. Berrangé wrote: > > On Wed, Sep 18, 2024 at 09:57:32PM +0900, Andrea Bolognani wrote: > > > On Wed, Sep 18, 2024 at 02:33:10PM GMT, Daniel P. Berrangé wrote: > > > > On Wed, Sep 18, 2024 at 04:32:25AM -0500, Andrea Bolognani wrote: > > > > > The libvirt-ci patches were incorrect, and AFAICT Cirrus CI simply > > > > > hasn't introduced support for macOS 15 yet, which isn't unexpected > > > > > since the OS was released mere days ago. So > > > > > > > > Their docs say only sonoma, but their underlying git repo does in > > > > fact show sequoia. They're currently exposing Beta images, which > > > > is probably why they don't document it yet. Assuming the CI job > > > > passes, I see no reason we can't use the sequoia images today though, > > > > as they'll get updated to non-beta versions soon enough > > > > > > > > https://github.com/cirruslabs/macos-image-templates > > > > > > I'd wait for them to be made GA. > > > > > > New macOS releases have historically introduced changes that require > > > libvirt to adapt, sometimes with significant effort, and I wouldn't > > > want anyone to spend time investigating a build failure that can > > > potentially affect the Beta version of the OS but not the GA one. > > > > Actually I'm wrong. Looking more closely the sequoia image there > > is an RC, not a Beta. The beta images was referring to 15.1, not > > 15.0, and they are named separately as sequoia-beta. Using an RC > > is reliable enough IMHO > > I still think there's no reason to rush before the image is GA'd, but > if the build job succeeds with the RC image and there is no post-GA > churn involved I won't stand in the way of a libvirt-ci MR taking > that approach instead of mine[1]. By that rationale we also won't test against rawhide, or sid, etc. IMHO the earlier we test against a platform the better, so if an image is available we should use it. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
