On Tue, Sep 17, 2024 at 12:32:46AM +0900, Andrea Bolognani wrote: > On Mon, Sep 16, 2024 at 04:15:58PM GMT, Daniel P. Berrangé wrote: > > A difference is that this Probe check will presumably report the error > > during daemon startup, while the virt-aa-helper check will delay the > > report until a VM is started. A failure to start the daemon is arguably > > more likely to be noticed & fixed at time of host deployment. > > The problem is that you won't get a daemon startup failure: libvirtd > will happily come up, just with AppArmor containment disabled. QEMU > domains will also start up just fine, except they'll be uncontained. Oh right, becuase we probe for the driver and decide it isn't available. Yes, lets kill this check. For your original patch Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
