Re: [PATCH 2/8] network: Do not call virNetworkObjUnsetDefTransient on start cleanup

[Laine Stump <laine@xxxxxxxxxx>]

On 9/3/24 10:36 AM, Martin Kletzander wrote:
> The function networkShutdownNetwork already does that.

(Harmless, but redundant)(or am I missing something?)

> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

Reviewed-by: Laine Stump <laine@xxxxxxxxxx>

> ---
>   src/network/bridge_driver.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index 5b510a222cd2..b16d524aa181 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -2387,7 +2387,6 @@ networkStartNetwork(virNetworkDriverState *driver,
>           virErrorPtr save_err;
>   
>           virErrorPreserveLast(&save_err);
> -        virNetworkObjUnsetDefTransient(obj);
>           networkShutdownNetwork(driver, obj);
>           virErrorRestore(&save_err);
>       }