Re: [PATCH] resctrl: Do not rewrite default MB values for new allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/16/24 10:33, Martin Kletzander wrote:
> The code did it "just in case" the allocation was not reset for new
> subdirectories.  That might've happened in the past with CAT settings,
> but checking it now it is properly reset to its maximum values for each
> new CLOSID (Class of Service ID).
> 
> The advantage of this is that we do not rewrite the value with itself
> which causes an issue with the current linux kernel and mba_MBps option
> where the default is UINT_MAX (or (uint32_t) -1), but gets rounded up to
> bandwidth granularity (10), overflows and small number (4) is set
> instead.
> 

Sounds like a kernel bug to me.

> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  src/util/virresctrl.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux