On 9/12/24 15:19, Martin Kletzander wrote: > On Wed, Aug 28, 2024 at 02:16:15PM +0200, Michal Privoznik wrote: >> So far, virCommandMassCloseGetFDsLinux() opens "/proc/self/fd", >> iterates over it marking opened FDs in @fds bitmap. Well, we can >> do the same on other systems (with altered path), like MacOS or >> FreeBSD. Therefore, isolate dir iteration into a separate >> function that accepts dir path as an argument. >> >> Unfortunately, this function might be unused on some systems >> (e.g. mingw), therefore mark it as such. >> > > Not in this patch. This patch should leave it in without marking it as > unused. With that Why not? A new function is introduced, outside of any #ifdef block, but it's used solely in #ifdef __linux__ (for now). Or am I missing something? > > Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx> Michal
