Re: [PATCH] vmx: Allow '*' to appear in VMX file keys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 11, 2024 at 05:03:16PM +0100, Richard W.M. Jones wrote:
> When connecting to a VMware server (eg using vpx://) we download and
> try to parse the VMware metadata '*.vmx' file of a guest.  In this
> case a VMX file was found which contained this key:
> 
>   pciPassthru*.present = "False"
> 
> The '*' character was not previously allowed in keys so this failed to
> parse with the error:
> 
>   VIR_ERR_CONF_SYNTAX: VIR_FROM_CONF: configuration file syntax error:
>   memory conf:74: expecting an assignment
> 
> Resolves: https://issues.redhat.com/browse/RHEL-58446
> Thanks: Daniel Berrange
> Signed-off-by: Richard W.M. Jones <rjones@xxxxxxxxxx>
> ---
>  src/util/virconf.c                       |   2 +-
>  tests/vmx2xmldata/esx-in-the-wild-14.vmx | 109 +++++++++++++++++++++++
>  tests/vmx2xmldata/esx-in-the-wild-14.xml |  35 ++++++++
>  tests/vmx2xmltest.c                      |   1 +
>  4 files changed, 146 insertions(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux