Re: [PATCH] qemuProcessSetupRawIO: Refactor return value and remove useless #ifdef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 03, 2024 at 10:50:07 +0200, Peter Krempa wrote:
> The function can return directly rather than setting 'ret' as there's no
> cleanup.
> 
> It also doesn't make sense to conditionally compile out the 'break'
> statement when checking whether a disk has rawio enabled if
> 'CAP_SYS_RAWIO' is _not_ defined as the function will still behave the
> same.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/qemu/qemu_process.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux