On Wed, Aug 21, 2024 at 03:36:03PM GMT, Kamil Szczęk wrote: > On Wednesday, August 21st, 2024 at 17:15, Michal Prívozník <mprivozn@xxxxxxxxxx> wrote: > > > We require that we're able to compile and tests pass after each commit > > (it's easier when we need to bisect something in the future). Therefore, > > I'm squashing 3/6 into 2/6. > > Makes sense, will keep that in mind. > > > and merged. Congratulations in your first libvirt contribution! > > Awesome, thanks. Looking forward to contributing further! I think the availability of this new feature should be advertised in the domain capabilities XML. That way, management applications such as virt-manager will be able to detect its presence and decide to ditch PS/2 completely for headless VMs, where it's not necessary to have any input devices. For VMs with graphics, they could add a USB keyboard to go along with the USB tablet that is already added, instead of the current combo of PS/2 keyboard and mouse *plus* USB tablet, for a slightly cleaner overall configuration matching that of other architectures that are not beholden to the same legacy as x86. -- Andrea Bolognani / Red Hat / Virtualization
