Re: [libvirt PATCH RFC] ci: adapt to 'dtrace' package split

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Wednesday in 2024, Martin Kletzander wrote:
On Wed, Aug 14, 2024 at 11:29:44PM +0200, Ján Tomko wrote:
Fedora has decided to separate dtrace out of the systemtap-sdt-devel
package: https://fedoraproject.org/wiki/Changes/Separate_dtrace_package

Similarly, these are split in OpenSUSE Tumbleweed, however in a
backward-compatbile way:
https://build.opensuse.org/package/show/openSUSE:Factory/systemtap

Require the new 'systemtap-sdt' package mapping, as well as the old
'dtrace'.

Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
---
This was generated from the libvirt-ci change from the following merge
request:
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/498

z>It is believed to fix the failure on Fedora Rawhide:
https://gitlab.com/janotomko/libvirt/-/pipelines/1413537405
(The failed job comes from a transient error on a cirrus builder)


I'm not sure what failure you are talking about.  The pipeline is green
since you posted this patch.


The current master still uses a container build of rawhide where
systemtap-sdt-devel still depends on systemtap-sdt-dtrace:

https://src.fedoraproject.org/rpms/systemtap/c/93948388bc54cd7a4efb1806d9787291d26b33d6?branch=rawhide
systemtap-sdt-devel-5.2~pre17224323g98d1ea34-1.fc41.x86_64
systemtap-sdt-dtrace-5.2~pre17224323g98d1ea34-1.fc41.x86_64

However in current rawhide, the packages no longer depend on each other:
(version 5.2~pre17224323g98d1ea34-2.fc41)
https://src.fedoraproject.org/rpms/systemtap/c/20b4dc7947b0a1197c48b0b26821ae698ba1902d?branch=rawhide

See my work-in-progres json-c pipeline that lead to a container refresh
and thus failure:
https://gitlab.com/janotomko/libvirt/-/jobs/7587452059

Shouldn't this be changed in libvirt.spec.in as well since it currently
says just:

# we need /usr/sbin/dtrace
BuildRequires: systemtap-sdt-devel

Maybe even to just
BuildRequires: /usr/sbin/dtrace

Yes, the specfile also needs to be changed.

We need both, I've seen errors about the sdt.h inclusion with just the
dtrace package installed.

Jano


??

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux