Re: [PATCH] virsh: schedinfo --set invalid=value would simply ignore the option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/11/2010 08:00 AM, Jim Meyering wrote:
> Currently, virsh does this:
> 
>     $ virsh -c test:///default schedinfo 1 --set j=k>/dev/null && echo bad
>     bad
> 
> It should have diagnosed "j=k" as an invalid schedinfo --set argument.

> +
> +: ${srcdir=$(pwd)}

As long as we are assuming a modern shell with $() support, can't we
also assume that $PWD is reliable and save a fork?

At any rate, ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]