Re: [libvirt PATCH 03/20] util: json: introduce virJSONStringPrettifyBlanks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 14, 2024 at 23:40:18 +0200, Ján Tomko wrote:
> A horribly named function for unifying formatting when pretty-printing
> empty JSON arrays and objects. Useful for having stable test output
> even if different JSON libraries format these differently.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  src/libvirt_private.syms |  1 +
>  src/util/virjson.c       | 34 ++++++++++++++++++++++++++++++++++
>  src/util/virjson.h       |  2 ++
>  3 files changed, 37 insertions(+)

[...]

> diff --git a/src/util/virjson.c b/src/util/virjson.c
> index 57707350da..0edf86cd1c 100644
> --- a/src/util/virjson.c
> +++ b/src/util/virjson.c
> @@ -1861,6 +1861,40 @@ virJSONStringReformat(const char *jsonstr,
>      return virJSONValueToString(json, pretty);
>  }
>  
> +/**
> + * virJSONStringPrettifyBlanks:
> + * @jsonstr: string to prettify
> + *
> + * In the pretty mode of printing, various versions of JSON libraries
> + * format empty arrays and objects differently.
> + *
> + * Unify this to "[]" and "{}" which are used by json-c 0.17 and newer.
> + * https://github.com/json-c/json-c/issues/778

Ah, I thought that we could drop this along with yajl removal ... too
bad.

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux