On Wed, Jul 17, 2024 at 21:21:37 +0300, Nikolai Barybin via Devel wrote:
The commit message should shortly state the job types we're about to
handle so that anyone looking at the commit doesn't need to go digging.
> Signed-off-by: Nikolai Barybin <nikolai.barybin@xxxxxxxxxxxxx>
> ---
> src/qemu/qemu_block.c | 2 ++
> src/qemu/qemu_blockjob.c | 6 +++++-
> src/qemu/qemu_blockjob.h | 2 ++
> src/qemu/qemu_domain.c | 4 ++++
> 4 files changed, 13 insertions(+), 1 deletion(-)
[...]
> diff --git a/src/qemu/qemu_blockjob.h b/src/qemu/qemu_blockjob.h
> index f1ac43b4c7..d4a3677050 100644
> --- a/src/qemu/qemu_blockjob.h
> +++ b/src/qemu/qemu_blockjob.h
> @@ -66,6 +66,8 @@ typedef enum {
> QEMU_BLOCKJOB_TYPE_INTERNAL,
> QEMU_BLOCKJOB_TYPE_CREATE,
> QEMU_BLOCKJOB_TYPE_BROKEN,
> + QEMU_BLOCKJOB_TYPE_SNAPSHOT_SAVE,
> + QEMU_BLOCKJOB_TYPE_SNAPSHOT_DELETE,
These should go above _BROKEN as _BROKEN is a libvirt-internal state and
not mapped to qemu.
