On 8/5/24 16:40, Purna Pavan Chandra wrote: > Current ch driver supports restore only for domains without any network > configuration defined. This was because libvirt explicitly passes network fds > and CH did not had support to restore with new net FDS. This support has been > added recently, https://github.com/cloud-hypervisor/cloud-hypervisor/pull/6402 > The changes in this patch series includes moving to socket communication for > restore api, create new net fds and pass them via SCM_RIGHTS to CH. > > New changes in v3: > * Rebase on latest master > * Fixe typos > * Mention improvements in NEWS.rst > > v2: https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/message/6TMMK4FQ7GVJM7EWZD2NWUEUFRUWFW24/ > > New changes in v2: > * Reword of few commints > * Add version checks in save/restore validations > * Add use_timeout in chSocketRecv > * Address Praveen Paladugu's comments > > v1: https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/thread/PT77VAI7RF2BUNR2HUIFM46WCP5DVEKV/ > > Purna Pavan Chandra (9): > ch: report response message instead of just code > ch: Pass net ids explicitly during vm creation > ch: refactor chProcessAddNetworkDevices > ch: support poll with -1 in chSocketRecv > ch: use monitor socket fd to send restore request > ch: refactor virCHMonitorSaveVM > ch: support restore with net devices > ch: kill CH process if restore fails > NEWS: Mention restore with n/w devices support for ch > > NEWS.rst | 6 + > src/ch/ch_capabilities.c | 6 + > src/ch/ch_capabilities.h | 1 + > src/ch/ch_driver.c | 29 +++-- > src/ch/ch_monitor.c | 62 +++++++---- > src/ch/ch_monitor.h | 6 +- > src/ch/ch_process.c | 233 +++++++++++++++++++++++++++++++-------- > 7 files changed, 260 insertions(+), 83 deletions(-) > Fixed couple of formatting issues and merged. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal