On Thu, Aug 08, 2024 at 16:33:25 +0200, Michal Prívozník wrote: > On 8/8/24 00:04, Kamil Szczęk wrote: > > A while back QEMU introduced a new machine option for disabling the > > i8042 PS/2 controller (commit 4ccd5fe22feb95137d325f422016a6473) > > which up until then was a built-in device included by all PC machine > > type descendants unconditionally. This new option allowed users to > > disable emulation of this controller, thus removing the default PS/2 > > peripherals. The rationale for why somebody might want to disable > > PS/2 peripherals is explained in the aforementioned commit. > > > > This introduces a new 'ps2' feature which, when disabled, results in > > no implicit PS/2 bus input devices being automatically added to the > > domain and addition of the 'i8042=off' machine option to the QEMU > > command-line. > > > > A notable side effect of disabling the i8042 controller in QEMU is that > > the vmport device won't be created. For this reason we will not allow > > setting the vmport feature if the ps2 feature is explicitly disabled. > > > > Signed-off-by: Kamil Szczęk <kamil@xxxxxxxxxx> > > --- > > docs/formatdomain.rst | 5 +++++ > > src/conf/domain_conf.c | 6 +++++- > > src/conf/domain_conf.h | 1 + > > src/conf/domain_validate.c | 23 +++++++++++++++++++++++ > > src/conf/schemas/domaincommon.rng | 5 +++++ > > src/qemu/qemu_capabilities.c | 21 +++++++++++++++++++++ > > src/qemu/qemu_capabilities.h | 4 ++++ > > src/qemu/qemu_command.c | 5 +++++ > > src/qemu/qemu_domain.c | 3 ++- > > src/qemu/qemu_validate.c | 23 +++++++++++++++++++++++ > > 10 files changed, 94 insertions(+), 2 deletions(-) > > Makes sense, but the fact you're adding new query command means > qemucapabilitiestest is now failing. You can either hand fix all > .replies files OR ask Peter to regenerate the files for you (he has an > authoritative setup with (nearly) all possible QEMU versions). I'll post an update soon, in fact this patch reminded me to do so. Note that this patchset is also missing any other form of test additions we require for new elemets (XML->XML, xml->commandline (also checking various versions for changed behaviour) etc). Also anything that touches qemu capability detection must be separated into a separate patch.
