On Wed, Jul 31, 2024 at 5:33 AM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whether we still want migration to randomly fail, like > > what this patch does. > > > > Or any better suggestions? I'm definitely open to that. > > > > Thanks, > > > > -- > > Peter Xu > > Randomly is an overstatement. You need to switch between kernels > where this feature differs. We did it with a ton of features > in the past, donnu why we single out USO now. I guess the reason is that for offload features other than USO they are landed in early kernels so we don't have a chance to test/meet this case. But this is not the case for USO. Thanks > > Basically downstreams just don't separately add kernel features vs > qemu features. There's little reason for them to do so. > > > > -- > MST >