On Wed, Jun 12, 2024 at 03:02:09 -0700, wucf@xxxxxxxxxxxxx wrote: > From: Chun Feng Wu <wucf@xxxxxxxxxxxxx> We tend to add also a justification/description of the change rather than just mechanically outline what you did: Introduce schema for defining '<throttlegroups>' element which configures throttling groups which can be configured for multiple disks. Or something similar. > * Refactor "diskIoTune" to extract common schema "iotune" > * Add new elements '<throttlegroups>' > * <ThrottleGroups> contains <ThrottleGroup> defintion, which references > "iotune" > > Signed-off-by: Chun Feng Wu <wucf@xxxxxxxxxxxxx> > --- > docs/formatdomain.rst | 26 +++ > src/conf/schemas/domaincommon.rng | 274 ++++++++++++++++-------------- > 2 files changed, 174 insertions(+), 126 deletions(-) > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index 00f861e385..b7e1f9cc83 100644 > --- a/docs/formatdomain.rst > +++ b/docs/formatdomain.rst > @@ -1957,6 +1957,32 @@ advertisements to the guest OS. (NB: Only qemu driver support) > the guest OS itself can choose to circumvent the unavailability of the sleep > states (e.g. S4 by turning off completely). > > +Disk Throttle Group Management > +------------------------------ > + > +:since:`Since 10.5.0` it is possible to create multiple named throttle groups Don't forget to update to '10.7.0' > +and then reference them within ``throttlefilters`` to form filter chain in QEMU for ... within ``throttlefilters`` sub-element of ``disk`` element ... > +specific disk. The limits(throttlegroups) are shared within domain, hence the same group > +can be referenced by different filters. Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
