On 7/24/24 13:02, Kristina Hanicova wrote: > If there are absent values in an already existing element > specifying rom settings, we simply use the old ones. This > behaviour is not desired, as users might think that deleting the > element from XML would delete the setting (because the hotplug > succeeds) - which does not happen. Because of that, we should not > accept an interface without elements that cannot be changed. > > Therefore, we should not allow absent values for already existing > rom setting during hotplug. > > Resolves: https://issues.redhat.com/browse/RHEL-7109 > > Signed-off-by: Kristina Hanicova <khanicov@xxxxxxxxxx> > --- > src/qemu/qemu_hotplug.c | 6 ------ > 1 file changed, 6 deletions(-) > While this has a chance to annoy users, it is the only sensible thing to do and we should never have had the code in the first place. It's bitten us too many times. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
