On Tue, 23 Jul 2024 at 12:42, Martin Kletzander <mkletzan@xxxxxxxxxx> wrote:
On Wed, May 29, 2024 at 06:49:06AM -0400, Abhiram Tilak wrote:
>Provides completers for auth-type and source-format commands for
>virsh pool-create-as and pool-define-as commands. Use Empty completers
>for options where completions are not required.
>
>Related Issue: https://gitlab.com/libvirt/libvirt/-/issues/9
>Signed-off-by: Abhiram Tilak <atp.exp@xxxxxxxxx>
>---
>Changes in v2:
> - Fix all formatting errors
> - Change some options using Empty completers, to use
> LocalPath completers.
> - Add completers for AdapterName and AdapterParent using information
> from node devices.
>
Those look just like virshNodeDeviceNameCompleter except the flags. It
would be shame to duplicate all that code, maybe amending that function
and using it here would be nicer.
Alright, I am not sure why I didn't do that already.
--
Abhiram
