On 7/16/24 11:40, Adam Julis wrote: > Add an element to configure the rlimit nofile size: > > ... > <binary> > <rlimit_nofile size='122333'/> > </binary> > ... > > Non-positive values are forbidden in 'domaincommon.rng'. Added separate > test file, created by modifying the 'vhost-user-fs-fd-memory.xml'. > > Resolves: https://gitlab.com/libvirt/libvirt/-/issues/485 This patch alone does not resolves the issue. We tend to put it into the very last commit that fixes the issue. > Signed-off-by: Adam Julis <ajulis@xxxxxxxxxx> > --- > docs/formatdomain.rst | 4 ++ > src/conf/domain_conf.c | 12 +++++ > src/conf/domain_conf.h | 1 + > src/conf/schemas/domaincommon.rng | 9 ++++ > ...vhost-user-fs-fd-rlimit.x86_64-latest.args | 34 +++++++++++++ > .../vhost-user-fs-fd-rlimit.x86_64-latest.xml | 50 +++++++++++++++++++ > .../vhost-user-fs-fd-rlimit.xml | 50 +++++++++++++++++++ > tests/qemuxmlconftest.c | 1 + > 8 files changed, 161 insertions(+) > create mode 100644 tests/qemuxmlconfdata/vhost-user-fs-fd-rlimit.x86_64-latest.args > create mode 100644 tests/qemuxmlconfdata/vhost-user-fs-fd-rlimit.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/vhost-user-fs-fd-rlimit.xml Since .xml and -latest.xml files are identical I suggest turning -latest.xml into a symlink pointing to the input .xml. Oh, and please next time, when you're sending two or more patches do not forget the cover letter. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
