On 7/9/24 17:23, Adam Julis wrote: > The "modify" command allows to replace an existing Srv record > (some of its elements respectively: port, priority and weight). > The primary key used to choose the modify record is the remaining > parameters, only one of them is required. Not using some of these > parameters may cause duplicate records and error message. This > logic is there because of the previous implementation (Add and > Delete options) in the function. > > Tests in networkxml2xmlupdatetest.c contain replacements of an > existing DNS-Srv record and failure due to non-existing record. > > Resolves: https://gitlab.com/libvirt/libvirt/-/issues/639 > Signed-off-by: Adam Julis <ajulis@xxxxxxxxxx> > --- > src/conf/network_conf.c | 27 ++++++++++++++----- > .../srv-not-existing.xml | 1 + > .../srv-record-modify-few.xml | 1 + > .../nat-network-dns-srv-modify-few.xml | 26 ++++++++++++++++++ > tests/networkxml2xmlupdatetest.c | 10 ++++++- > 5 files changed, 58 insertions(+), 7 deletions(-) > create mode 100644 tests/networkxml2xmlupdatein/srv-not-existing.xml > create mode 100644 tests/networkxml2xmlupdatein/srv-record-modify-few.xml > create mode 100644 tests/networkxml2xmlupdateout/nat-network-dns-srv-modify-few.xml Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
