Re: [PATCH 3/9] qemuxmlconfdata: Drop tests relying on <qemu-5.2.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 01, 2024 at 13:41:37 +0200, Michal Privoznik wrote:
> Soon, the minimal version of QEMU is going to be bumped to 5.2.0.
> Drop test cases that require older version.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  82 files changed, 3515 deletions(-)
>  delete mode 100644 tests/qemuxmlconfdata/aarch64-gic-default.aarch64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/aarch64-gic-default.aarch64-4.2.0.xml
>  delete mode 100644 tests/qemuxmlconfdata/aarch64-gic-none.aarch64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/aarch64-gic-none.aarch64-4.2.0.xml
>  delete mode 100644 tests/qemuxmlconfdata/aarch64-virt-virtio.aarch64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/aarch64-virt-virtio.aarch64-4.2.0.xml


>  delete mode 100644 tests/qemuxmlconfdata/iothreads-disk-virtio-ccw.s390x-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/iothreads-disk-virtio-ccw.s390x-4.2.0.xml
>  delete mode 100644 tests/qemuxmlconfdata/iothreads-disk-virtio-ccw.xml

This specific case is removed completely. Normally that wouldn't be
something we want to do in a commit like this, but in this case, there's
not much sense in testing iothreads specifically as they share common
code and we do have other code paths testing CCW disks, so it's okay.
I'd mention it in the commit message though.


>  delete mode 100644 tests/qemuxmlconfdata/q35-default-devices-only.x86_64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/q35-default-devices-only.x86_64-4.2.0.xml

>  delete mode 100644 tests/qemuxmlconfdata/q35-multifunction.x86_64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/q35-multifunction.x86_64-4.2.0.xml

>  delete mode 100644 tests/qemuxmlconfdata/q35-pcie-autoadd.x86_64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/q35-pcie-autoadd.x86_64-4.2.0.xml

>  delete mode 100644 tests/qemuxmlconfdata/q35-pcie.x86_64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/q35-pcie.x86_64-4.2.0.xml

>  delete mode 100644 tests/qemuxmlconfdata/q35-virt-manager-basic.x86_64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/q35-virt-manager-basic.x86_64-4.2.0.xml

>  delete mode 100644 tests/qemuxmlconfdata/sound-device.x86_64-4.2.0.args
>  delete mode 100644 tests/qemuxmlconfdata/sound-device.x86_64-4.2.0.xml

I've originally wanted to have a look at what the specific pinned
versions of the test cases above were testing, but 4.2.0 was the oldest
one and thus in many cases it wasn't really clear why it's picked.

Thus I didn't go through these in detail, but in the future this work
should become much simpler.

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux