Re: [PATCH v2 03/14] hw/s390x: convert 'ccw' machine definitions to use new macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/6/24 18:57, Daniel P. Berrangé wrote:
This changes the DEFINE_CCW_MACHINE macro to use the common
helpers for constructing versioned symbol names and strings,
bringing greater consistency across targets.

The added benefit is that it avoids the need to repeat the
version number twice in two different formats in the calls
to DEFINE_CCW_MACHINE.

A DEFINE_CCW_MACHINE_AS_LATEST helper is added so that it
is not required to pass 'false' for every single historical
machine type.

Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
  hw/s390x/s390-virtio-ccw.c | 96 +++++++++++++++++++++-----------------
  1 file changed, 53 insertions(+), 43 deletions(-)

Nice!

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux