On Wed, Jun 12, 2024 at 03:25:46PM -0400, Laine Stump wrote: > When the chain names and table name used by the nftables firewall > backend were changed in commit > 958aa7f274904eb8e4678a43eac845044f0dcc38, I forgot to change the test > data file base.nftables, which has the extra "list" and "add > chain/table" commands that are generated for the first test case of > networkxml2firewalltest.c. When the full set of tests is run, the > first test will be an iptables test case, so those extra commands > won't be added to any of the nftables cases, and so the data in > base.nftables never matches, and the tests are all successful. > > However, if the test are limited with, e.g. VIR_TEST_RANGE=2 (test #2 > will be the nftables version of the 1st test case), then the commands > to add nftables table/chains *will* be generated in the test output, > and so the test will fail. Because I was only running the entire test > series after the initial commits of nftables tests, I didn't notice > this. Until now. > > base.nftables has now been updated to reflect the current names for > chains/table, and running individual test cases is once again > successful. > > Fixes: 958aa7f274904eb8e4678a43eac845044f0dcc38 > Signed-off-by: Laine Stump <laine@xxxxxxxxxx> > --- > tests/networkxml2firewalldata/base.nftables | 202 ++++---------------- > 1 file changed, 42 insertions(+), 160 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> and pushed With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
