Re: [PATCH 06/12] qemu_monitor: Allow querying SEV-SNP state in 'query-sev'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 20, 2024 at 01:22:43PM +0200, Michal Privoznik wrote:
> In QEMU commit v9.0.0-1155-g59d3740cb4 the return type of
> 'query-sev' monitor command changed to accommodate SEV-SNP. Even
> though we currently support launching plain SNP guests, this will
> soon change.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c       | 32 ++++++++++--------
>  src/qemu/qemu_monitor.c      |  7 ++--
>  src/qemu/qemu_monitor.h      | 41 +++++++++++++++++++----
>  src/qemu/qemu_monitor_json.c | 63 ++++++++++++++++++++++++++++------
>  src/qemu/qemu_monitor_json.h |  8 ++---
>  tests/qemumonitorjsontest.c  | 65 ++++++++++++++++++++++++++++++++----
>  6 files changed, 167 insertions(+), 49 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


>      return 0;
> +
> + error_report:

Nitpick  ...   s/error_report/error/

> +    virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                   _("query-sev reply was missing some data"));
> +    return -1;
>  }

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux