On 6/13/24 16:50, Jonathon Jongsma wrote:
> Commit 7c8e606b64c73ca56d7134cb16d01257f39c53ef attempted to fix
> the specification of the ramfb property for vfio-pci devices, but it
> failed when ramfb is explicitly set to 'off'. This is because only the
> 'vfio-pci-nohotplug' device supports the 'ramfb' property. Since we use
> the base 'vfio-pci' device unless ramfb is enabled, attempting to set
> the 'ramfb' parameter to 'off' this will result in an error like the
> following:
>
> error: internal error: QEMU unexpectedly closed the monitor
> (vm='rhel'): 2024-06-06T04:43:22.896795Z qemu-kvm: -device
> {"driver":"vfio-pci","host":"0000:b1:00.4","id":"hostdev0","display":"on
> ","ramfb":false,"bus":"pci.7","addr":"0x0"}: Property 'vfio-pci.ramfb'
> not found.
>
> This also more closely matches what is done for mdev devices.
>
> Resolves: https://issues.redhat.com/browse/RHEL-28808
>
> Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
> ---
> src/qemu/qemu_command.c | 6 ++++--
> .../hostdev-pci-display-ramfb.x86_64-latest.args | 2 +-
> 2 files changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
Michal
