On 6/17/24 15:51, Adam Julis wrote: > Although existing virDomainDefPostParse is called after modifying > the XML and it contains validating process for changed device, > the virDomainDefValidate function performs a more comprehensive > check. It should detect errors resulting from dependencies > between devices. Therefore, the virDomainDefValidate is added at > the end. > PostParse should refrain from doing any validation. I believe what you meant to say is: virDomainDeviceDefParse() calls virDomainDeviceDefValidate(). I'm changing the commit message a bit and merging. > Signed-off-by: Adam Julis <ajulis@xxxxxxxxxx> > --- > src/qemu/qemu_driver.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
