On Mon, Jun 10, 2024 at 01:57:21PM +0200, Michal Prívozník wrote:
> On 6/7/24 16:26, Daniel P. Berrangé wrote:
> > We'll want to access these paths from outside the TLS context code,
> > so split them into a standalone file.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> > src/rpc/meson.build | 6 +-
> > src/rpc/virnettlsconfig.c | 202 +++++++++++++++++++++++++++++++++++++
> > src/rpc/virnettlsconfig.h | 68 +++++++++++++
> > src/rpc/virnettlscontext.c | 70 ++-----------
> > 4 files changed, 285 insertions(+), 61 deletions(-)
> > create mode 100644 src/rpc/virnettlsconfig.c
> > create mode 100644 src/rpc/virnettlsconfig.h
> >
> > diff --git a/src/rpc/meson.build b/src/rpc/meson.build
> > index 9d98bc6259..d11d532d0f 100644
> > --- a/src/rpc/meson.build
> > +++ b/src/rpc/meson.build
> > @@ -1,6 +1,10 @@
> > gendispatch_prog = find_program('gendispatch.pl')
> >
> > -socket_sources = [
> > +tlsconfig_sources = [
> > + files('virnettlsconfig.c'),
> > +]
>
> I believe this should be either:
>
> tlsconfig_sources = [ ... ]
This doesn't work as we need the sub-dir remembered, so that a later
patch in the series can reference this from the tools/ subdir.
> or
>
> tlsconfig_sources = files( ... )
>
> and given that the latter remembers the subdir of passed files then I'd
> just stick to it.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
