On Mon, Jun 03, 2024 at 10:57:15AM GMT, Daniel P. Berrangé wrote:
> On Tue, May 28, 2024 at 05:49:21PM +0200, Andrea Bolognani wrote:
> > +++ b/libvirt.spec.in
> > @@ -1387,6 +1387,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec)
> > %{?enable_werror} \
> > -Dexpensive_tests=enabled \
> > -Dinit_script=systemd \
> > + -Dfirewall_backend_priority=nftables,iptables \
>
> This change isn't right as it doesn't match earlier logic in the spec
> which is version specific
>
> %if 0%{?rhel} >= 10 || 0%{?fedora} >= 41
> Requires: nftables
> %else
> Requires: iptables
> %endif
>
> ie, we should *not* be preferring nftables on existing RHEL and Fedora,
> only future, otherwise users will get a functional behaviour change
> on their existing distro.
You're right. I'll fix it. Unfortunately 10.4.0 has already been
tagged :(
--
Andrea Bolognani / Red Hat / Virtualization
