On Wed, May 29, 2024 at 09:51:36 +0200, Michal Privoznik wrote: > When removing rotated log files, their name is matched against a > regex (@log_regex) and if they contain '.N' suffix the 'N' is > then parsed into an integer. Well, due to a bug in > virLogCleanerParseFilename() this is not how the code works. If > the suffix isn't found then g_match_info_fetch() returns an empty > string instead of NULL which then makes str2int parsing fail. > Just check for this case before parsing the string. > > Based on the original patch sent by David. > > Reported-by: David Negreira <david.negreira@xxxxxxxxxxxxx> > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > > The original patch was posted here: > > https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/thread/ENXJABODLWWXAR6RSKGMG6GAJKZMVKKM/ > > In the thread you can see me suggesting this alternative approach and > David confirming it works. Therefore, I'd like to get this in before the > release. > > src/logging/log_cleaner.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
