Re: [PATCH 4/6] vsh: Close stderr among with stdin in cmdComplete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 27, 2024 at 11:18:52 +0200, Michal Privoznik wrote:
> Our completer callbacks must refrain from printing anything onto
> stderr, but unfortunately that's not how service code around
> behaves. It may call vshError() and what not. Rather trying to
> fix all possible paths (just consider opening a connection), just
> close the stderr. We're already closing stdin.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  tools/vsh.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux