Re: [PATCH] rpc: avoid leak of GSource in use for interrupting main loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/17/24 15:58, Daniel P. Berrangé wrote:
> We never release the reference on the GSource created for
> interrupting the main loop, nor do we remove it from the
> main context if our thread is woken up prior to the wakeup
> callback firing.
> 
> This can result in a leak of GSource objects, along with an
> ever growing list of GSources attached to the main context,
> which will gradually slow down execution of the loop, as
> several operations are O(N) for the number of attached GSource
> objects.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/rpc/virnetclient.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux