On 5/16/24 11:23, Andrea Bolognani wrote: > On Thu, May 16, 2024 at 10:03:02AM GMT, Daniel P. Berrangé wrote: >> On Thu, May 16, 2024 at 10:24:22AM +0200, Andrea Bolognani wrote: >>> As a general rule, we use defines for features that can only be >>> enabled on a subset of the platforms that we target, and we >>> don't offer fine-grained control over every single possible >>> meson configuration knob at the RPM level. >>> >>> In the case of ssh-proxy, we are enabling it everywhere already, >>> so having a define for it is unnecessary. >> >> The only reason for a conditional would be if some older distro lacks >> support for this SSH proxy'ing feature. Assuming RHEL-9 / Ubuntu 22.04 >> have it, then this is indeed redundant > > We don't need to worry about Ubuntu in the spec file ;) > > IIUC requirements are mostly on the guest OS side, and on the host OS > side we just need the ssh ProxyCommand feature which would have been > available since forever. Michal, can you please confirm that this is > accurate? > Indeed. I just wanted to give distro maintainers ability to fine tune what features they enable. But I guess it makes sens to have this always enabled. Michal
