On Thu, May 16, 2024 at 10:24:20AM +0200, Andrea Bolognani wrote:
> The way things are implemented, installing the package not
> only makes the feature available but also enables it.
>
> Some admins might not want that to happen, so let's make the
> dependency a weak one to offer them a way out.
The whole reason for existance of the 'libvirt-daemon-{kvm,qemu}'
packages is to install the *entire* feature set relevant to QEMU/
KVM.
If admins want to select individual components, then pick the
actual sub-RPMs desire, and ignore libvirt-daemon{kvm,qemu}
meta packages.
>
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
> libvirt.spec.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 5cb19fa433..329b923e8f 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -905,7 +905,7 @@ Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release}
> Requires: libvirt-daemon-driver-secret = %{version}-%{release}
> Requires: libvirt-daemon-driver-storage = %{version}-%{release}
> %if %{with_ssh_proxy}
> -Requires: libvirt-ssh-proxy = %{version}-%{release}
> +Recommends: libvirt-ssh-proxy = %{version}-%{release}
> %endif
> Requires: qemu
>
> @@ -936,7 +936,7 @@ Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release}
> Requires: libvirt-daemon-driver-secret = %{version}-%{release}
> Requires: libvirt-daemon-driver-storage = %{version}-%{release}
> %if %{with_ssh_proxy}
> -Requires: libvirt-ssh-proxy = %{version}-%{release}
> +Recommends: libvirt-ssh-proxy = %{version}-%{release}
> %endif
> Requires: qemu-kvm
>
> --
> 2.45.0
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
