Re: [PATCH 04/13] security: Fix return types of .probe callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 06, 2024 at 10:43:01AM +0200, Michal Privoznik wrote:
> The .probe member of virSecurityDriver struct is declared to
> return virSecurityDriverStatus enum. But there are two instances
> (AppArmorSecurityManagerProbe() and
> virSecuritySELinuxDriverProbe()) where callbacks are defined to
> return an integer. This is an undefined behavior because integer
> has strictly bigger space of possible values than the enum.
> 
> Defined those aforementioned callbacks so that they return the
> correct enum instead of int.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/security/security_apparmor.c | 2 +-
>  src/security/security_selinux.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux