[RFC 6/6] test_driver: dump: store dump flags as payload

[Thanos Makatos <thanos.makatos@xxxxxxxxxxx>]

This way we can inspect the dump file and confirm that the test_driver
really used the dump format we specified.

Signed-off-by: Thanos Makatos <thanos.makatos@xxxxxxxxxxx>
---
 src/test/test_driver.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 2a31511e3e..4f78f39de9 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -2663,6 +2663,8 @@ static int testDomainCoreDumpWithFormat(virDomainPtr domain,
     virDomainObj *privdom;
     virObjectEvent *event = NULL;
     int ret = -1;
+    char *buf = NULL;
+    int size;
 
     virCheckFlags(VIR_DUMP_CRASH | VIR_DUMP_LIVE | VIR_DUMP_BYPASS_CACHE |
                   VIR_DUMP_MEMORY_ONLY, -1);
@@ -2680,7 +2682,13 @@ static int testDomainCoreDumpWithFormat(virDomainPtr domain,
                              domain->name, to);
         goto cleanup;
     }
-    if (safewrite(fd, TEST_SAVE_MAGIC, sizeof(TEST_SAVE_MAGIC)) < 0) {
+    ret = asprintf(&buf, "%s_%u", TEST_SAVE_MAGIC, dumpformat);
+    if (ret == -1) {
+        goto cleanup;
+    }
+    size = ret;
+    ret = -1;
+    if (safewrite(fd, buf, size) < 0) {
         virReportSystemError(errno,
                              _("domain '%1$s' coredump: failed to write header to %2$s"),
                              domain->name, to);
@@ -2712,6 +2720,7 @@ static int testDomainCoreDumpWithFormat(virDomainPtr domain,
 
     ret = 0;
  cleanup:
+    free(buf);
     VIR_FORCE_CLOSE(fd);
     virDomainObjEndAPI(&privdom);
     virObjectEventStateQueue(privconn->eventState, event);
-- 
2.30.2
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx