On Sun, Apr 21, 2024 at 10:53:16PM -0400, Laine Stump wrote: > We will already need a separate function for virFirewallApplyCmd for > iptables vs. nftables, but the only reason for needing a separate > function for virFirewallAddCmd* is that iptables/ebtables need to have > an extra arg added for locking (to prevent multiple iptables commands > from running at the same time). We can just as well add in the > -w/--concurrent during virFirewallApplyCmd, so move the arg-add to > ApplyCmd to keep AddCmd simple. > > Signed-off-by: Laine Stump <laine@xxxxxxxxxx> > --- > src/util/virfirewall.c | 27 +++++++++++++-------------- > 1 file changed, 13 insertions(+), 14 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx