Re: [PATCH v2 23/27] rpm: drop BuildRequires for iptables and ebtables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 21, 2024 at 10:53:31PM -0400, Laine Stump wrote:
> The only reason for requiring these was so that meson could search for
> the binary location, and the previous patch eliminated that, so we no
> longer need them at build time.
> 
> Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
> ---
>  libvirt.spec.in | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>

though I'd suggest it could just be squashed into the previous patch

> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index bde25c6f6e..05f7a7e7c0 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -356,8 +356,6 @@ BuildRequires: sanlock-devel >= 2.4
>  BuildRequires: libpcap-devel >= 1.5.0
>  BuildRequires: libnl3-devel
>  BuildRequires: libselinux-devel
> -BuildRequires: iptables
> -BuildRequires: ebtables
>  # For modprobe
>  BuildRequires: kmod
>  BuildRequires: cyrus-sasl-devel
> -- 
> 2.44.0
> _______________________________________________
> Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux