On 05/03/2010 12:43 PM, Matthias Bolte wrote:
>> -dnsmasqReload(pid_t pid)
>> +dnsmasqReload(pid_t pid ATTRIBUTE_UNUSED)
>> {
>> +#ifndef __MINGW32__
>
> Typically, WIN32 instead of __MINGW32__ is used in the libvirt code
> base. Cygwin doesn't define WIN32, so this won't interfere with a
> Cygwin build.
for exp in MINGW32 WIN32; do
git grep $exp -- tools lib daemon | wc
done
shows 4 of the former, and 13 of the latter. Patch updated accordingly,
and I'm working on a followup to make it consistent.
>
>> if (kill(pid, SIGHUP) != 0) {
>> virReportSystemError(errno,
>> _("Failed to make dnsmasq (PID: %d) reload config files.\n"),
>
> You could kill the \n here.
Sure, as long as I'm in the area.
>
> ACK
Thanks, and applied with your suggested updates.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list