On Thu, Apr 18, 2024 at 05:01 PM -0500, Jonathon Jongsma <jjongsma@xxxxxxxxxx> wrote: > On 4/12/24 8:36 AM, Marc Hartmayer wrote: >> Use the proper driver functions for the node state shutdown preparation and >> wait. In the next patch, these functions will be extended. >> >> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> >> --- >> src/node_device/node_device_udev.c | 54 >> +++++++++++++++++++++++------- […snip…] > > > Reviewed-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> Thanks, but I found some issues/improvements for this patch (or maybe I’ve to split them into two patches), the new version of the prepare will do the following: nodeStateShutdownPrepare: 1. unref all priv->mdevctlMonitors 2. remove priv->watch 3. remove priv->timeout 4. set priv->udevThreadQuit = true and virConSignal... 5. virWorkerPoolStop(...) In addition, the new functions …ShutdownPrepare and …ShutdownWait must be called in the cleanup path of nodeStateInitialize for a proper cleanup, because before this change these things were done in ‘nodeStateCleanup‘ and this function is already called in the cleanup path of nodeStateInitialize. Fine with you? If yes, I’ll send a new version. > -- Kind regards / Beste Grüße Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
