Re: [PATCH 0/2] A couple of fixes for non-standard builddir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Friday in 2024, Michal Privoznik wrote:
The other day somebody on #virt complained about test suite failing on a
fresh checkout. Turned out, our mocking and some bash scripts are not
prepared for a case when there's a space in builddir path.

After these, there are still some tests failing, but my brain is too
small to fix them:

1) Somehow, $builddir/docs/html/libvirt-libvirt-common.html (and friends) are
  generated into $builddir/html/libvirt-libvirt-common.html and I can't
  figure out why. This means, check-html and check-html-references tests
  are failing.

2) There's some problem with po_check as it fails to find generated
  sources (like src/remote/remote_client_bodies.h). I've taken look
  into our syntax-check.mk but I have no idea what's wrong nor how to
  properly escape paths in Makefile.

Michal Prívozník (2):
 tests: mock: Accept spaces in build path
 tests: Allow spaces in path to virt-aa-helper

tests/securityselinuxlabeltest.c |  2 +-
tests/securityselinuxtest.c      |  2 +-
tests/testutils.c                |  6 ++++--
tests/testutils.h                | 12 +++++++++++-
tests/viridentitytest.c          |  2 +-
tests/virt-aa-helper-test        |  4 ++--
6 files changed, 20 insertions(+), 8 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux