On Wed, Apr 10, 2024 at 09:42 AM +0200, Ján Tomko <jtomko@xxxxxxxxxx> wrote:
> On a Tuesday in 2024, Marc Hartmayer wrote:
>>On Thu, Mar 28, 2024 at 03:55 PM +0100, Ján Tomko <jtomko@xxxxxxxxxx> wrote:
>>> On a Wednesday in 2024, Marc Hartmayer wrote:
>>>>Make sure the old value in `scsi_target->wwpn` is free'd before replacing it.
>>>>While at it, simplify the code.
>>>>
>>>
>>> "While at it" usually means it should have been a separate commit,
>>> especially if the simplification changes the behavior of the code.
>>>
>>
>>Looks like this patch has been merged:
>>
>>5138dd247870 ("node_device_conf: virNodeDeviceGetSCSITargetCaps: fix
>>memory leak")
>>
>
> Oh, I haven't seen Michal's R-b. Maybe there was a mailing list
> outage?
No, it was my fault… I’ve sent the first version to the old libvirt ML +
Michal on CC…
>
>>Shall we revert it and apply the patch in the mail “[PATCH v1]
>>node_device_conf: virNodeDeviceGetSCSITargetCaps: fix memory leak”
>>instead?
>>
>
> I think that if you have to ask, it's not worth the hassle.
>
> Jano
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
