Re: [PATCH] qemusecuritytest: Call real virFileExists in mock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 09, 2024 at 10:41:37 +0200, Michal Privoznik wrote:
> When I suggested to Jim to call real virFileExists() I forgot to
> also suggest calling init_syms(). Without it, real_virFileExists
> pointer might be left unset. And indeed, that's what we were
> seeing on FreeBSD.
> 
> This effectively reverts commit 4b5cc57ed35dc24d11673dd3f04bfb8073c0340d.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> 
> Green pipeline:
> 
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1245457856
> 
> Okay, it doesn't test FreeBSD, but it tests x86_64-ubuntu-2204-clang
> which was also experiencing the failure:
> 
> https://gitlab.com/libvirt/libvirt/-/jobs/6574951734
> 
>  tests/qemusecuritymock.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux