On 3/26/24 12:37, Benjamin Taubmann wrote: > At the moment, there is no configuration option for the libvirt-guests > service that allows users to define that only persistent virtual machines > should be shutdown on host shutdown. > > Currently, the service config allows to choose between two ON_SHUTDOWN > actions that are executed on running virtual machines when the host goes > down: shutdown, suspend. > The ON_SHUTDOWN action should be orthogonal to the type of the virtual > machine. However, the existing implementation, does not suspend > transient virtual machines. > This is the matrix of actions that is executed on virtual machines based > on the configured ON_SHUTDOWN action and the type of a virtual machine. > > | persistent | transient > shutdown | shutdown | shutdown (what we want to change) > suspend | suspend | nothing > > Add config option PERSISTENT_ONLY to libvirt-guests config that allows > users to define if the ON_SHUTDOWN action should be applied only on > persistent virtual machines. PERSISTENT_ONLY can be set to true, false, > default. The default option will implement the already existing logic. > > Case 1: PERSISTENT_ONLY=default > | persistent | transient > shutdown | shutdown | shutdown > suspend | suspend | nothing > > Case 2: PERSISTENT_ONLY=true > | persistent | transient > shutdown | shutdown | nothing > suspend | suspend | nothing > > Case 3: PERSISTENT_ONLY=false > | persistent | transient > shutdown | shutdown | shutdown > suspend | suspend | suspend > > Signed-off-by: Benjamin Taubmann <benjamin.taubmann@xxxxxxxxxxx> > Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > --- > v2: Update libvirt-guests' man page and git commit message > --- > docs/manpages/libvirt-guests.rst | 22 +++++++++++++++++++ > tools/libvirt-guests.sh.in | 37 ++++++++++++++++++++++++++------ > 2 files changed, 52 insertions(+), 7 deletions(-) Merged now. Michal _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
