On Wed, Mar 27, 2024 at 10:51:14AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:14 +0100 > From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > Subject: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove > PCMachineClass::enforce_aligned_dimm > X-Mailer: git-send-email 2.41.0 > > PCMachineClass::enforce_aligned_dimm was only used by the > pc-i440fx-2.1 machine, which got removed. It is now always > true. Remove it, simplifying pc_get_device_memory_range(). > Update the comment in Avocado test_phybits_low_pse36(). > > Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > --- > include/hw/i386/pc.h | 3 --- > hw/i386/pc.c | 14 +++----------- > tests/avocado/mem-addr-space-check.py | 3 +-- > 3 files changed, 4 insertions(+), 16 deletions(-) [snip] > diff --git a/tests/avocado/mem-addr-space-check.py b/tests/avocado/mem-addr-space-check.py > index af019969c0..ad75170d52 100644 > --- a/tests/avocado/mem-addr-space-check.py > +++ b/tests/avocado/mem-addr-space-check.py > @@ -31,8 +31,7 @@ def test_phybits_low_pse36(self): > at 4 GiB boundary when "above_4g_mem_size" is 0 (this would be true when > we have 0.5 GiB of VM memory, see pc_q35_init()). This means total > hotpluggable memory size is 60 GiB. Per slot, we reserve 1 GiB of memory > - for dimm alignment for all newer machines (see enforce_aligned_dimm > - property for pc machines and pc_get_device_memory_range()). That leaves > + for dimm alignment for all machines. That leaves Just nit, better align it here. Reviewed-by: Zhao Liu <zhao1.liu@xxxxxxxxx> > total hotpluggable actual memory size of 59 GiB. If the VM is started > with 0.5 GiB of memory, maxmem should be set to a maximum value of > 59.5 GiB to ensure that the processor can address all memory directly. > -- > 2.41.0 > _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
