On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: > On Tue, 26 Mar 2024 14:29:58 +0100 > Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote: > > > Hi Igor, > > > > On 26/3/24 14:08, Thomas Huth wrote: > > > > > > s/iaspc/isapc/ in the subject > > > > > > On 26/03/2024 13.51, Igor Mammedov wrote: > > >> ISAPC machine was introduced 25 years ago and it's a lot of time since > > >> such machine was around with real ISA only PC hardware practically > > >> defunct. > > >> Also it's slowly bit-rots (for example: I was able to boot RHEL6 on > > >> RHEL9 host > > >> in only TCG mode, while in KVM mode it hung in the middle of boot) > > > > I'm quite opposed to this patch. QEMU models various very-old / > > defunct hardware. I'm pretty sure Bernhard and myself are OK to > > keep maintaining it, besides we are working in separating it from > > the i440fx+piix machine. Also, this machine is particularly > > interesting for my single-binary experiments. > > it would not be fair to ask you or Bernard to deal with every > case where ISAPC related code gets in a way, nor it's fair to > ask other contributors to ensure that their patches don't break > semi-working ISAPC or refactor code that relates to it. > > [ > for example I'd like to refactor smbios parts in the image > ACPI table builder, but the I'd have to do it for legacy > part as well without means to verify that. Sure it can be > done but at cost of extra time spent to rewrite something > that would never be used and to find test env to verify > touched code. > ] Is SMBIOS even relevant for isapc ? IIUC, the first SMBIOS spec is from 1999, while PCI has been around since 1992. IOW, we shouldn't even be exposing SMBIOS with the isapc machine type. If we address that, then isapc has no impact on your ability to refactor SMBIOS code. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
