|
Please advise on what actions (if any) should be taken so that the changes in the patch is merged into main.
Cheers,
Mostafa Mahmoud.
From: m kamal <recenum@xxxxxxxxxxx>
Sent: Tuesday, March 12, 2024 5:58 PM To: Peter Krempa <pkrempa@xxxxxxxxxx> Cc: devel@xxxxxxxxxxxxxxxxx <devel@xxxxxxxxxxxxxxxxx> Subject: Re: [PATCH v2] Remove VIR_FREE in favor of g_autofree in some functions in libvrit-domain.c
Thanks a lot for the review, Peter.
The first name I used was by mistake, it's the name of my Github profile, Github desktop probably auto-configured it as the global user name for git on my machine. It's in Arabic so it could confuse many non-Unicode-aware programs or protocols. The other name
"m kamal" is just a contraction I wrote when I was subscribing to the mailing list from the web UI, I didn't realize it's important.
I will change my configured name in the .gitpublish config to be the longer name "Mostafa Mahmoud", that's the first 2 names of my legal name, it appears that most names here are also 2 names. If there is also a way to change my forum name "m kamal" please
let me know.
Sorry for any inconvenience. One last question: After the patch got your approval, is there something on my end to do so that it gets merged? Will it automatically gets picked up by the Gitlab CI pipeline somehow?
Cheers,
Mostafa Mahmoud.
From: Peter Krempa <pkrempa@xxxxxxxxxx>
Sent: Tuesday, March 12, 2024 9:57 AM To: Mostafa <recenum@xxxxxxxxxxx> Cc: devel@xxxxxxxxxxxxxxxxx <devel@xxxxxxxxxxxxxxxxx> Subject: Re: [PATCH v2] Remove VIR_FREE in favor of g_autofree in some functions in libvrit-domain.c On Tue, Mar 12, 2024 at 00:11:28 +0200, Mostafa wrote:
The patch looks good now, but you've used multiple names in various fields over the two postings and the preference in terms of both authorship and sign-off is to use a full real name Used previously: > From: مصطفي محمود كمال الدين <48567303+moste00@xxxxxxxxxxxxxxxxxxxxxxxx> > From: m kamal <recenum@xxxxxxxxxxx> The one in this patch: > Signed-off-by: Mostafa <recenum@xxxxxxxxxxx> I don't want to assume anything about foreign names, but the last one looks more like a nickname or given name only. > --- > src/libvirt-domain.c | 32 ++++++++------------------------ > 1 file changed, 8 insertions(+), 24 deletions(-) For the code: Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx> |
_______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
