Our documentation in most places explicitly mentions --diskspec and it was never meant to be positional, although we can't change the parser any more. Annotate them as 'unwanted_positional'. Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- tools/virsh-checkpoint.c | 1 + tools/virsh-snapshot.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index 869c071700..65061cbf3d 100644 --- a/tools/virsh-checkpoint.c +++ b/tools/virsh-checkpoint.c @@ -206,6 +206,7 @@ static const vshCmdOptDef opts_checkpoint_create_as[] = { }, {.name = "diskspec", .type = VSH_OT_ARGV, + .unwanted_positional = true, .help = N_("disk attributes: disk[,checkpoint=type][,bitmap=name]") }, {.name = NULL} diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 899bae7e9a..638333f4d6 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -361,6 +361,7 @@ static const vshCmdOptDef opts_snapshot_create_as[] = { }, {.name = "diskspec", .type = VSH_OT_ARGV, + .unwanted_positional = true, .help = N_("disk attributes: disk[,snapshot=type][,driver=type][,stype=type][,file=name]") }, {.name = NULL} -- 2.44.0 _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx