[PATCH 09/11] ch_driver: Add additional validation for save/restore

[Purna Pavan Chandra Aekkaladevi <paekkaladevi@xxxxxxxxxxxxxxxxxxx>]

Save & Restore are supported without any network and hostdev config
defined. So, add a validation for it before performing save.

Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkaladevi@xxxxxxxxxxxxxxxxxxx>
---
 src/ch/ch_driver.c | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c
index 09cd6b90e7..3d5b8d211a 100644
--- a/src/ch/ch_driver.c
+++ b/src/ch/ch_driver.c
@@ -679,6 +679,26 @@ chDomainDestroy(virDomainPtr dom)
     return chDomainDestroyFlags(dom, 0);
 }
 
+static int
+chDomainSaveAdditionalValidation(virDomainDef *vmdef)
+{
+    /*
+    SAVE and RESTORE are functional only without any networking and
+    device passthrough configuration
+    */
+    if (vmdef->nnets > 0) {
+        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
+                       _("cannot save domain with network interfaces"));
+        return -1;
+    }
+    if  (vmdef->nhostdevs > 0) {
+        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
+                       _("cannot save domain with host devices"));
+        return -1;
+    }
+    return 0;
+}
+
 /**
  * chDoDomainSave:
  * @driver: pointer to driver structure
@@ -701,13 +721,17 @@ chDoDomainSave(virCHDriver *driver,
     g_autoptr(virCHDriverConfig) cfg = virCHDriverGetConfig(driver);
     virCHDomainObjPrivate *priv = vm->privateData;
     CHSaveXMLHeader hdr;
+    virDomainState domainState;
     g_autofree char *to = NULL;
     g_autofree char *xml = NULL;
     uint32_t xml_len;
     VIR_AUTOCLOSE fd = -1;
     int ret = -1;
 
-    virDomainState domainState = virDomainObjGetState(vm, NULL);
+    if (chDomainSaveAdditionalValidation(vm->def) < 0)
+        goto end;
+
+    domainState = virDomainObjGetState(vm, NULL);
     if (domainState == VIR_DOMAIN_RUNNING) {
         if (virCHMonitorSuspendVM(priv->monitor) < 0) {
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx